Changeset 161789 in webkit for trunk/Source/JavaScriptCore/ChangeLog

Timestamp:

Jan 11, 2014, 6:51:19 PM (12 years ago)

Author:

Brent Fulgham

Message:

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
​https://bugs.webkit.org/show_bug.cgi?id=126754

Patch by Dean Jackson <​[email protected]> on 2014-01-11
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

• js/script-tests/typedarray-constructors.js: Added.
• js/typedarray-constructors-expected.txt: Added.
• js/typedarray-constructors.html: Added.
• resources/standalone-pre.js: Add missing 'shouldNotThrow'

method (duplicated from resources/js-test-pre.js)

File:

• trunk/Source/JavaScriptCore/ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-11  Dean Jackson  <[email protected]>
+
+        [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
+        https://bugs.webkit.org/show_bug.cgi?id=126754
+
+        Reviewed by Filip Pizlo.
+
+        The ECMAScript specification forbids calling the typed array
+        constructors without using "new". Change the call data to return
+        none so we throw and exception in these cases.
+
+        * runtime/JSGenericTypedArrayViewConstructorInlines.h:
+        (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
+
 2014-01-11  Anders Carlsson  <[email protected]>