Changeset 162720 in webkit for trunk/Source/JavaScriptCore/debugger/Debugger.cpp

Timestamp:

Jan 24, 2014, 1:27:42 PM (11 years ago)

Author:

Joseph Pecoraro

Message:

fast/profiler tests ASSERTing after moving recompileAllJSFunctions off a timer
​https://bugs.webkit.org/show_bug.cgi?id=127566

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Make the VM handle recompilation as soon as possible after it is requested.

• debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):
When in a JavaScript stack, mark for recompilation when possible.

• runtime/VMEntryScope.h:

(JSC::VMEntryScope::setRecompilationNeeded):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
Handle recompilation when the top VMEntryScope is popped.
Pass the needs recompilation flag up the stack if needed.

Source/WebCore:

Covered by existing tests.

• testing/Internals.cpp:

(WebCore::Internals::closeDummyInspectorFrontend):
Now that we don't have to fake that this is a page being destroyed to
avoid recompilation. Use the InspectorDestroyed reason.

File:

• trunk/Source/JavaScriptCore/debugger/Debugger.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/debugger/Debugger.cpp

@@ -323 +323 @@
     // If JavaScript is running, it's not safe to recompile, since we'll end
     // up throwing away code that is live on the stack.
-    ASSERT(!vm->entryScope);
-    if (vm->entryScope)
-        return;
-    
+    if (vm->entryScope) {
+        vm->entryScope->setRecompilationNeeded(true);
+        return;
+    }
+
     vm->prepareToDiscardCode();