Changeset 162777 in webkit for trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp

Timestamp:

Jan 25, 2014, 1:16:42 PM (11 years ago)

Author:

[email protected]

Message:

Remove atomicIncrement/atomicDecrement
​https://bugs.webkit.org/show_bug.cgi?id=127625

Reviewed by Andreas Kling.

Replace atomicIncrement/atomicDecrement with std::atomic.

Source/JavaScriptCore:

• bytecode/Watchpoint.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::addDatabaseToAtExit):

Source/WebCore:

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::incrementActiveSourceCount):
(WebCore::AudioContext::decrementActiveSourceCount):

• Modules/webaudio/AudioContext.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):

• Modules/webaudio/AudioNode.h:
• Modules/webdatabase/OriginLock.h:

Source/WebKit2:

• Platform/IPC/Connection.cpp:

(IPC::Connection::createSyncMessageEncoder):

• Shared/mac/SecItemShim.cpp:

(WebKit::generateSecItemRequestID):

• UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::addOutstandingRequest):

Source/WTF:

• wtf/Atomics.h:
• wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

• wtf/RefCountedLeakCounter.h:
• wtf/ThreadSafeRefCounted.h:

(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):

File:

• trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp

@@ -34 +34 @@
 namespace JSC { namespace Profiler {
 
-#if COMPILER(MINGW) || COMPILER(MSVC7_OR_LOWER) || OS(WINCE)
-static int databaseCounter;
-#else
-static volatile int databaseCounter;
-#endif
+static std::atomic<int> databaseCounter;
+
 static SpinLock registrationLock = SPINLOCK_INITIALIZER;
-static int didRegisterAtExit;
+static std::atomic<int> didRegisterAtExit;
 static Database* firstDatabase;
 
 Database::Database(VM& vm)
-    : m_databaseID(atomicIncrement(&databaseCounter))
+    : m_databaseID(++databaseCounter)
     , m_vm(vm)
     , m_shouldSaveAtExit(false)
@@ -139 +136 @@
 void Database::addDatabaseToAtExit()
 {
-    if (atomicIncrement(&didRegisterAtExit) == 1)
+    if (++didRegisterAtExit == 1)
         atexit(atExitCallback);