Changeset 162796 in webkit for trunk/Source/JavaScriptCore/profiler/Profile.cpp

Timestamp:

Jan 25, 2014, 10:30:38 PM (11 years ago)

Author:

[email protected]

Message:

Remove dead code from the JSC profiler.

​https://bugs.webkit.org/show_bug.cgi?id=127643

Reviewed by Mark Lam.

Source/JavaScriptCore:

• profiler/Profile.cpp:
• profiler/Profile.h:
• profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::stopProfiling):

• profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::stopProfiling):
(JSC::ProfileNode::endAndRecordCall):
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

• profiler/ProfileNode.h:

(JSC::ProfileNode::totalTime):
(JSC::ProfileNode::setTotalTime):
(JSC::ProfileNode::selfTime):
(JSC::ProfileNode::setSelfTime):
(JSC::ProfileNode::totalPercent):
(JSC::ProfileNode::selfPercent):
Remove support for things like focus and exclude. The Inspector does those in JS now.

Source/WebCore:

Passes existing tests in fast/profiler.

• bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor): Remove visible.

• inspector/ScriptProfileNode.idl: Ditto.
• inspector/protocol/Profiler.json: Ditto.

Source/WebInspectorUI:

• Versions/Inspector-iOS-7.0.json: Remove visible from CPUProfileNode.

LayoutTests:

• fast/profiler/resources/profiler-test-JS-resources.js:

(printProfileNodeWithoutTime): Don't use visible. It was always true.

File:

• trunk/Source/JavaScriptCore/profiler/Profile.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/profiler/Profile.cpp

@@ -66 +66 @@
 }
 
-void Profile::focus(const ProfileNode* profileNode)
-{
-    if (!profileNode || !m_head)
-        return;
-
-    bool processChildren;
-    const CallIdentifier& callIdentifier = profileNode->callIdentifier();
-    for (ProfileNode* currentNode = m_head.get(); currentNode; currentNode = currentNode->traverseNextNodePreOrder(processChildren))
-        processChildren = currentNode->focus(callIdentifier);
-
-    // Set the visible time of all nodes so that the %s display correctly.
-    forEach(&ProfileNode::calculateVisibleTotalTime);
-}
-
-void Profile::exclude(const ProfileNode* profileNode)
-{
-    if (!profileNode || !m_head)
-        return;
-
-    const CallIdentifier& callIdentifier = profileNode->callIdentifier();
-
-    for (ProfileNode* currentNode = m_head.get(); currentNode; currentNode = currentNode->traverseNextNodePreOrder())
-        currentNode->exclude(callIdentifier);
-
-    // Set the visible time of the head so the %s display correctly.
-    m_head->setVisibleTotalTime(m_head->totalTime() - m_head->selfTime());
-    m_head->setVisibleSelfTime(0.0);
-}
-
-void Profile::restoreAll()
-{
-    forEach(&ProfileNode::restore);
-}
-
 #ifndef NDEBUG
 void Profile::debugPrintData() const