Changeset 163517 in webkit for trunk/Source/JavaScriptCore/dfg/DFGJITCode.h

Timestamp:

Feb 5, 2014, 11:11:48 PM (12 years ago)

Author:

[email protected]

Message:

Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have
​https://bugs.webkit.org/show_bug.cgi?id=128234

Reviewed by Geoffrey Garen.

Use DFG::JITCode::osrEntryRetry as a counter to decide when to invoke OSR entry. That
comes into play only after we've done a replacement compile.

This appears to still give us a speed-up on the kinds of things that OSR entry is good
for, while also eliminating pointless OSR entry compilations on other things.

• dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::JITCode):

• dfg/DFGJITCode.h:
• dfg/DFGOperations.cpp:
• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

• runtime/Options.h:

File:

• trunk/Source/JavaScriptCore/dfg/DFGJITCode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGJITCode.h

@@ -126 +126 @@
     ExecutionCounter tierUpCounter;
     RefPtr<CodeBlock> osrEntryBlock;
+    unsigned osrEntryRetry;
+    bool abandonOSREntry;
 #endif // ENABLE(FTL_JIT)
 };