Changeset 163576 in webkit for trunk/Source/JavaScriptCore/jit/JITWriteBarrier.h

Timestamp:

Feb 6, 2014, 4:42:21 PM (11 years ago)

Author:

[email protected]

Message:

Heap::writeBarrier shouldn't be static
​https://bugs.webkit.org/show_bug.cgi?id=127807

Reviewed by Geoffrey Garen.

Currently it looks up the Heap in which to fire the write barrier by using
the cell passed to it. Almost every call site already has a reference to the
VM or the Heap itself. It seems wasteful to look it up all over again.

Source/JavaScriptCore:

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopyWriteBarrier.h:

(JSC::CopyWriteBarrier::set):

• heap/Heap.cpp:

(JSC::Heap::writeBarrier):

• heap/Heap.h:

(JSC::Heap::writeBarrier):

• jit/JITOperations.cpp:
• jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

• runtime/Arguments.h:
• runtime/JSWeakMap.cpp:
• runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

• runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

• runtime/Structure.h:
• runtime/WriteBarrier.h:
• runtime/WriteBarrierInlines.h: Added.

Source/WebCore:

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

• bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

File:

• trunk/Source/JavaScriptCore/jit/JITWriteBarrier.h (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JITWriteBarrier.h

@@ -78 +78 @@
     }
 
-    void set(VM&, CodeLocationDataLabelPtr location, JSCell* owner, JSCell* value)
+    void set(VM& vm, CodeLocationDataLabelPtr location, JSCell* owner, JSCell* value)
     {
-        Heap::writeBarrier(owner, value);
+        vm.heap.writeBarrier(owner, value);
         m_location = location;
         ASSERT(((!!m_location) && m_location.executableAddress() != JITWriteBarrierFlag) || (location.executableAddress() == m_location.executableAddress()));