Changeset 164439 in webkit for trunk/Source/JavaScriptCore/API/ObjCCallbackFunction.mm

Timestamp:

Feb 20, 2014, 11:40:04 AM (11 years ago)

Author:

[email protected]

Message:

Dynamically generated JSExport protocols added to a class results in a crash
​https://bugs.webkit.org/show_bug.cgi?id=129108

Reviewed by Oliver Hunt.

We're not getting any information from the runtime about the types of the methods on
these protocols because they didn't exist at compile time. We should handle this gracefully.

• API/ObjCCallbackFunction.mm:

(objCCallbackFunctionForInvocation):

• API/tests/JSExportTests.mm:

(+[JSExportTests exportDynamicallyGeneratedProtocolTest]):
(runJSExportTests):

File:

• trunk/Source/JavaScriptCore/API/ObjCCallbackFunction.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/API/ObjCCallbackFunction.mm

@@ -633 +633 @@
 static JSObjectRef objCCallbackFunctionForInvocation(JSContext *context, NSInvocation *invocation, CallbackType type, Class instanceClass, const char* signatureWithObjcClasses)
 {
+    if (!signatureWithObjcClasses)
+        return nil;
+
     const char* position = signatureWithObjcClasses;