Changeset 164456 in webkit for trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp

Timestamp:

Feb 20, 2014, 4:00:12 PM (11 years ago)

Author:

[email protected]

Message:

FTL may not see a compact_unwind section if there weren't any stackmaps
​https://bugs.webkit.org/show_bug.cgi?id=129125

Reviewed by Geoffrey Garen.

It's OK to not have an unwind section, so long as the function also doesn't have any
OSR exits.

• ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):

• ftl/FTLUnwindInfo.cpp:

(JSC::FTL::UnwindInfo::parse):

• ftl/FTLUnwindInfo.h:

File:

• trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp

@@ -49 +49 @@
 } // anonymous namespace
 
-void UnwindInfo::parse(void* section, size_t size, GeneratedFunction generatedFunction)
+bool UnwindInfo::parse(void* section, size_t size, GeneratedFunction generatedFunction)
 {
     m_registers.clear();
     
-    RELEASE_ASSERT(section);
+    RELEASE_ASSERT(!!section == !!size);
+    if (!section)
+        return false;
+    
     RELEASE_ASSERT(size >= sizeof(CompactUnwind));
     
@@ -157 +160 @@
     
     std::sort(m_registers.begin(), m_registers.end());
+    return true;
 }