Changeset 164651 in webkit for trunk/Source/JavaScriptCore/dfg/DFGNode.h

Timestamp:

Feb 25, 2014, 9:47:29 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, roll out ​http://trac.webkit.org/changeset/164493.

It causes crashes, apparently because it's removing too many barriers. I will investigate
later.

• bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

• bytecode/SpeculatedType.h:
• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):

• dfg/DFGNode.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotNully):
(JSC::FTL::LowerDFGToLLVM::isNully):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

File:

• trunk/Source/JavaScriptCore/dfg/DFGNode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGNode.h

@@ -1501 +1501 @@
     }
 
-    bool shouldSpeculateOther()
-    {
-        return isOtherSpeculation(prediction());
-    }
-
     bool shouldSpeculateCell()
     {
         return isCellSpeculation(prediction());
-    }
-    
-    bool shouldSpeculateNotCell()
-    {
-        return isNotCellSpeculation(prediction());
     }