Changeset 164953 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

Timestamp:

Mar 2, 2014, 3:14:47 PM (11 years ago)

Author:

[email protected]

Message:

Clean up use of Options::enableConcurrentJIT().
<​https://webkit.org/b/129582>

Reviewed by Filip Pizlo.

DFG Driver was conditionally checking Options::enableConcurrentJIT()
only if ENABLE(CONCURRENT_JIT). Otherwise, it bypasses it with a local
enableConcurrentJIT set to false.

Instead we should configure Options::enableConcurrentJIT() to be false
in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always
check Options::enableConcurrentJIT(). This makes the code read a little
cleaner.

• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

File:

• trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp

@@ -93 +93 @@
         new Plan(codeBlock, profiledDFGCodeBlock, mode, osrEntryBytecodeIndex, mustHandleValues));
     
-    bool enableConcurrentJIT;
-#if ENABLE(CONCURRENT_JIT)
-    enableConcurrentJIT = Options::enableConcurrentJIT();
-#else // ENABLE(CONCURRENT_JIT)
-    enableConcurrentJIT = false;
-#endif // ENABLE(CONCURRENT_JIT)
-    if (enableConcurrentJIT) {
+    if (Options::enableConcurrentJIT()) {
         Worklist* worklist = ensureGlobalWorklistFor(mode);
         plan->callback = callback;