Changeset 165073 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

Timestamp:

Mar 4, 2014, 1:30:59 PM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r164812.
​http://trac.webkit.org/changeset/164812
​https://bugs.webkit.org/show_bug.cgi?id=129699

it made things run slower (Requested by pizlo on #webkit).

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• jsc.cpp:

(GlobalObject::finishCreation):

• runtime/BatchedTransitionOptimizer.h:

(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
(JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -1180 +1180 @@
             variableObject->globalObject()->varInjectionWatchpoint()->fireAll();
 
-        {
-            SamplingRegion samplingRegion("variable puts");
-            
-            for (unsigned i = 0; i < numVariables; ++i) {
-                const Identifier& ident = codeBlock->variable(i);
-                if (!variableObject->hasProperty(callFrame, ident)) {
-                    PutPropertySlot slot(variableObject);
-                    variableObject->methodTable()->put(variableObject, callFrame, ident, jsUndefined(), slot);
-                }
+        for (unsigned i = 0; i < numVariables; ++i) {
+            const Identifier& ident = codeBlock->variable(i);
+            if (!variableObject->hasProperty(callFrame, ident)) {
+                PutPropertySlot slot(variableObject);
+                variableObject->methodTable()->put(variableObject, callFrame, ident, jsUndefined(), slot);
             }
         }
 
-        {
-            SamplingRegion samplingRegion("function puts");
-            
-            for (int i = 0; i < numFunctions; ++i) {
-                FunctionExecutable* function = codeBlock->functionDecl(i);
-                PutPropertySlot slot(variableObject);
-                variableObject->methodTable()->put(variableObject, callFrame, function->name(), JSFunction::create(vm, function, scope), slot);
-            }
+        for (int i = 0; i < numFunctions; ++i) {
+            FunctionExecutable* function = codeBlock->functionDecl(i);
+            PutPropertySlot slot(variableObject);
+            variableObject->methodTable()->put(variableObject, callFrame, function->name(), JSFunction::create(vm, function, scope), slot);
         }
     }