Changeset 165109 in webkit for trunk/Source/JavaScriptCore/heap/CodeBlockSet.cpp

Timestamp:

Mar 5, 2014, 8:46:23 AM (11 years ago)

Author:

[email protected]

Message:

Use range-based loops where possible in Heap methods
​https://bugs.webkit.org/show_bug.cgi?id=129513

Reviewed by Mark Lam.

Replace old school iterator based loops with the new range-based loop hotness
for a better tomorrow.

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::clearMarks):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
(JSC::CodeBlockSet::traceMarked):

• heap/Heap.cpp:

(JSC::Heap::visitProtectedObjects):
(JSC::Heap::visitTempSortVectors):
(JSC::Heap::clearRememberedSet):

• heap/Heap.h:

(JSC::Heap::forEachProtectedCell):

File:

• trunk/Source/JavaScriptCore/heap/CodeBlockSet.cpp (modified) (5 diffs)

trunk/Source/JavaScriptCore/heap/CodeBlockSet.cpp

@@ -42 +42 @@
 CodeBlockSet::~CodeBlockSet()
 {
-    HashSet<CodeBlock*>::iterator iter = m_set.begin();
-    HashSet<CodeBlock*>::iterator end = m_set.end();
-    for (; iter != end; ++iter)
-        (*iter)->deref();
+    for (CodeBlock* codeBlock : m_set)
+        codeBlock->deref();
 }
 
@@ -57 +55 @@
 void CodeBlockSet::clearMarks()
 {
-    HashSet<CodeBlock*>::iterator iter = m_set.begin();
-    HashSet<CodeBlock*>::iterator end = m_set.end();
-    for (; iter != end; ++iter) {
-        CodeBlock* codeBlock = *iter;
+    for (CodeBlock* codeBlock : m_set) {
         codeBlock->m_mayBeExecuting = false;
         codeBlock->m_visitAggregateHasBeenCalled = false;
@@ -76 +71 @@
         dataLog("Fixpointing over unmarked, set size = ", m_set.size(), "...\n");
     for (;;) {
-        HashSet<CodeBlock*>::iterator iter = m_set.begin();
-        HashSet<CodeBlock*>::iterator end = m_set.end();
-        for (; iter != end; ++iter) {
-            CodeBlock* codeBlock = *iter;
+        for (CodeBlock* codeBlock : m_set) {
             if (!codeBlock->hasOneRef())
                 continue;
@@ -91 +83 @@
         if (toRemove.isEmpty())
             break;
-        for (unsigned i = toRemove.size(); i--;)
-            m_set.remove(toRemove[i]);
+        for (CodeBlock* codeBlock : toRemove)
+            m_set.remove(codeBlock);
         toRemove.resize(0);
     }
@@ -107 +99 @@
     if (verbose)
         dataLog("Tracing ", m_set.size(), " code blocks.\n");
-    HashSet<CodeBlock*>::iterator iter = m_set.begin();
-    HashSet<CodeBlock*>::iterator end = m_set.end();
-    for (; iter != end; ++iter) {
-        CodeBlock* codeBlock = *iter;
+    for (CodeBlock* codeBlock : m_set) {
         if (!codeBlock->m_mayBeExecuting)
             continue;