Changeset 165152 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.cpp

Timestamp:

Mar 5, 2014, 5:46:21 PM (11 years ago)

Author:

[email protected]

Message:

Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=128625
Add fast mapping from StringImpl to JSString

Unreviewed roll-out.

Reverting r164347, r165054, r165066 - not clear the performance tradeoff was right.

• runtime/JSString.cpp:
• runtime/JSString.h:
• runtime/VM.cpp:

(JSC::VM::createLeaked):

• runtime/VM.h:

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=128625
Add fast mapping from StringImpl to JSString

Unreviewed roll-out.

Reverting r164347, r165054, r165066 - not clear the performance tradeoff was right.

• bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::clearWrappers):

• bindings/js/DOMWrapperWorld.h:
• bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

• bindings/scripts/StaticString.pm:

(GenerateStrings):

Source/WTF: [Win32][LLINT] Crash when running JSC stress tests.
​https://bugs.webkit.org/show_bug.cgi?id=129429

Patch by ​[email protected] <​[email protected]> on 2014-03-05
Reviewed by Geoffrey Garen.

• wtf/Platform.h: Enable LLINT on Win32.

File:

• trunk/Source/JavaScriptCore/runtime/JSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSString.cpp

@@ -299 +299 @@
 }
 
-void JSString::WeakOwner::finalize(Handle<Unknown>, void* context)
-{
-    StringImpl* impl = static_cast<StringImpl*>(context);
-    WeakSet::deallocate(impl->weakJSString());
-    impl->setWeakJSString(nullptr);
-}
-
 } // namespace JSC