Changeset 165205 in webkit for trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h

Timestamp:

Mar 6, 2014, 12:16:38 PM (11 years ago)

Author:

[email protected]

Message:

FTL arity fixup should work on ARM64
​https://bugs.webkit.org/show_bug.cgi?id=129810

Reviewed by Michael Saboff.

• Using regT5 to pass the thunk return address to arityFixup is shady since that's a callee-save.

• The FTL path was assuming X86 conventions for where SP points at the top of the prologue.

This makes some more tests pass.

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::prologueStackPointerDelta):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• jit/ThunkGenerators.cpp:

(JSC::arityFixup):

• llint/LowLevelInterpreter64.asm:
• offlineasm/arm64.rb:
• offlineasm/x86.rb: In addition to the t7 change, make t6 agree with GPRInfo.h.

File:

• trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/jit/AssemblyHelpers.h

@@ -69 +69 @@
 
 #if CPU(X86_64) || CPU(X86)
-    size_t prologueStackPointerDelta()
+    static size_t prologueStackPointerDelta()
     {
         // Prologue only saves the framePointerRegister
@@ -104 +104 @@
 
 #if CPU(ARM) || CPU(ARM64)
-    size_t prologueStackPointerDelta()
+    static size_t prologueStackPointerDelta()
     {
         // Prologue saves the framePointerRegister and linkRegister
@@ -139 +139 @@
 
 #if CPU(MIPS)
-    size_t prologueStackPointerDelta()
+    static size_t prologueStackPointerDelta()
     {
         // Prologue saves the framePointerRegister and returnAddressRegister
@@ -162 +162 @@
 
 #if CPU(SH4)
-    size_t prologueStackPointerDelta()
+    static size_t prologueStackPointerDelta()
     {
         // Prologue saves the framePointerRegister and link register