Ignore:
Timestamp:
Mar 6, 2014, 12:16:38 PM (11 years ago)
Author:
[email protected]
Message:

FTL arity fixup should work on ARM64
https://bugs.webkit.org/show_bug.cgi?id=129810

Reviewed by Michael Saboff.

  • Using regT5 to pass the thunk return address to arityFixup is shady since that's a callee-save.


  • The FTL path was assuming X86 conventions for where SP points at the top of the prologue.


This makes some more tests pass.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::prologueStackPointerDelta):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/ThunkGenerators.cpp:

(JSC::arityFixup):

  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm64.rb:
  • offlineasm/x86.rb: In addition to the t7 change, make t6 agree with GPRInfo.h.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/offlineasm/arm64.rb

    r164673 r165205  
    1 # Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
     1# Copyright (C) 2011, 2012, 2014 Apple Inc. All rights reserved.
    22#
    33# Redistribution and use in source and binary forms, with or without
     
    119119        when 't6'
    120120            arm64GPRName('x6', kind)
     121        when 't7'
     122            arm64GPRName('x7', kind)
    121123        when 'cfr'
    122124            arm64GPRName('x29', kind)
Note: See TracChangeset for help on using the changeset viewer.