Changeset 165293 in webkit for trunk/Source/JavaScriptCore/ftl/FTLSlowPathCall.cpp

Timestamp:

Mar 7, 2014, 2:22:46 PM (11 years ago)

Author:

[email protected]

Message:

Clarify how we deal with "special" registers
​https://bugs.webkit.org/show_bug.cgi?id=129806

Already reviewed change being relanded.

Relanding change set r165196 as it wasn't responsible for the breakage reported in
​https://bugs.webkit.org/show_bug.cgi?id=129822. That appears to be a build or

Reviewed by Michael Saboff.
configuration issue.

• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::lastRegister):

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::nextRegister):

• ftl/FTLLocation.cpp:

(JSC::FTL::Location::restoreInto):

• ftl/FTLSaveRestore.cpp:

(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):

• ftl/FTLSlowPathCall.cpp:
• jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):
(JSC::RegisterSet::runtimeRegisters):
(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::calleeSaveRegisters):

• jit/RegisterSet.h:

File:

• trunk/Source/JavaScriptCore/ftl/FTLSlowPathCall.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ftl/FTLSlowPathCall.cpp

@@ -53 +53 @@
         , m_returnRegister(returnRegister)
     {
-        // We don't care that you're using callee-save or stack registers.
+        // We don't care that you're using callee-save, stack, or hardware registers.
         m_usedRegisters.exclude(RegisterSet::stackRegisters());
+        m_usedRegisters.exclude(RegisterSet::reservedHardwareRegisters());
         m_usedRegisters.exclude(RegisterSet::calleeSaveRegisters());