Changeset 165320 in webkit for trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

Timestamp:

Mar 7, 2014, 7:33:44 PM (11 years ago)

Author:

[email protected]

Message:

.cfi directives in LowLevelInterpreter.cpp are providing no benefit
​https://bugs.webkit.org/show_bug.cgi?id=129945

Reviewed by Mark Lam.

Removed .cfi directive. Verified that stack traces didn't regress in crash reporter
or in lldb.

• llint/LowLevelInterpreter.cpp:

File:

• trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

@@ -493 +493 @@
 
 // These are for building an interpreter from generated assembly code:
-#if CPU(X86_64) && COMPILER(CLANG)
-#define OFFLINE_ASM_BEGIN   asm (                \
-    ".cfi_startproc\n"
-
-#define OFFLINE_ASM_END                          \
-    ".cfi_endproc\n"                             \
-                            );
-#else
 #define OFFLINE_ASM_BEGIN   asm (
 #define OFFLINE_ASM_END     );
-#endif
 
 #define OFFLINE_ASM_OPCODE_LABEL(__opcode) OFFLINE_ASM_GLOBAL_LABEL(llint_##__opcode)
@@ -516 +507 @@
     ".thumb_func " THUMB_FUNC_PARAM(label) "\n"  \
     SYMBOL_STRING(label) ":\n"
-#elif CPU(XXX86_64) && COMPILER(CLANG)
-#define OFFLINE_ASM_GLOBAL_LABEL(label)         \
-    ".text\n"                                   \
-    ".globl " SYMBOL_STRING(label) "\n"         \
-    HIDE_SYMBOL(label) "\n"                     \
-    SYMBOL_STRING(label) ":\n"                  \
-    ".cfi_def_cfa_offset 16\n"                  \
-    ".cfi_offset %rbp, -16\n"                   \
-    ".cfi_def_cfa_register rbp\n"
 #else
 #define OFFLINE_ASM_GLOBAL_LABEL(label)         \