Ignore:
Timestamp:
Mar 12, 2014, 8:41:55 AM (11 years ago)
Author:
Bem Jones-Bey
Message:

[CSS Shapes] Remove deprecated shapes
https://bugs.webkit.org/show_bug.cgi?id=125235

Reviewed by Dirk Schulze.

Source/WebCore:

Remove support for deprecated shape types and syntax. These have
already been removed from the CSS Shapes specification, so this aligns
the implementation with the specification.

The "new" tests below were simply moved from the old csswg directory,
as they were the only tests there that applied to the current syntax.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-polygon-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-polygon-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-polygon-002.html

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:
  • css/CSSBasicShapes.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShape):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor):

  • rendering/style/BasicShapes.cpp:
  • rendering/style/BasicShapes.h:

LayoutTests:

Remove tests for deprecated shape syntax.

There are also a few shape-inside tests that have been removed because
they were very difficult to make work without the rectangle shape, and
the future of the current shape-inside implementation is questionable
at best.

  • animations/resources/animation-test-helpers.js:

(parseBasicShape):

  • compositing/contents-opaque/opaque-with-clip-path-expected.html:
  • compositing/contents-opaque/opaque-with-clip-path.html:
  • css3/masking/clip-path-animation-expected.txt:
  • css3/masking/clip-path-animation.html:
  • css3/masking/clip-path-rectangle-expected.txt: Removed.
  • css3/masking/clip-path-rectangle.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Removed.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Removed.
  • fast/masking/parsing-clip-path-shape-expected.txt:
  • fast/masking/parsing-clip-path-shape.html:
  • fast/regions/shape-inside/shape-inside-on-additional-regions.html:
  • fast/regions/shape-inside/shape-inside-on-first-region-block-content.html:
  • fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html:
  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html:
  • fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html: Removed.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html:
  • fast/regions/shape-inside/shape-inside-on-regions-expected.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content.html:
  • fast/regions/shape-inside/shape-inside-on-regions.html:
  • fast/regions/shape-inside/shape-inside-on-second-region-block-content.html:
  • fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html:
  • fast/regions/shape-inside/shape-inside-recursive-layout-expected.html:
  • fast/regions/shape-inside/shape-inside-recursive-layout.html:
  • fast/regions/shape-inside/shape-inside-with-region-borders.html:
  • fast/regions/shape-inside/shape-inside-with-region-padding.html:
  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/css-shapes-enabled-expected.txt:
  • fast/shapes/css-shapes-enabled.html:
  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-inside.html:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside.html:
  • fast/shapes/parsing/parsing-test-utils.js:
  • fast/shapes/resources/simple-rectangle.js:

(drawTextRectangle):

  • fast/shapes/shape-inside/shape-inside-animation-expected.txt:
  • fast/shapes/shape-inside/shape-inside-animation.html:
  • fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html:
  • fast/shapes/shape-inside/shape-inside-bottom-edge.html:
  • fast/shapes/shape-inside/shape-inside-box-sizing.html:
  • fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html:
  • fast/shapes/shape-inside/shape-inside-dynamic-nested.html:
  • fast/shapes/shape-inside/shape-inside-dynamic-shape.html:
  • fast/shapes/shape-inside/shape-inside-dynamic-text.html:
  • fast/shapes/shape-inside/shape-inside-empty-expected.html:
  • fast/shapes/shape-inside/shape-inside-empty.html:
  • fast/shapes/shape-inside/shape-inside-inline-elements-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-inline-elements.html: Removed.
  • fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html:
  • fast/shapes/shape-inside/shape-inside-multiple-blocks.html:
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:
  • fast/shapes/shape-inside/shape-inside-outside-shape.html:
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html:
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html:
  • fast/shapes/shape-inside/shape-inside-overflow.html:
  • fast/shapes/shape-inside/shape-inside-percentage-auto.html:
  • fast/shapes/shape-inside/shape-inside-percentage.html:
  • fast/shapes/shape-inside/shape-inside-rectangle-padding-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rectangle-padding.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-004.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Removed.
  • fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding.html: Removed.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html:
  • fast/shapes/shape-inside/shape-inside-text.html:
  • fast/shapes/shape-inside/shape-inside-vertical-text.html:
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
  • fast/shapes/shape-outside-floats/shape-outside-animation.html:
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html:
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html:
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-rectangle-negative-width-crash-expected.txt: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-img-inset-rectangle-negative-width-crash.html: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-not-a-layer.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
  • fast/shapes/shape-outside-floats/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
  • fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html:
  • svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg: Removed.
  • svg/clip-path/clip-path-shape-rounded-rect-1.svg: Removed.
  • svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg: Removed.
  • svg/clip-path/clip-path-shape-rounded-rect-2.svg: Removed.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/css/CSSBasicShapes.cpp

    r165277 r165472  
    4141namespace WebCore {
    4242
    43 static String buildRectangleString(const String& x, const String& y, const String& width, const String& height, const String& radiusX, const String& radiusY, const String& box)
    44 {
    45     char opening[] = "rectangle(";
    46     char separator[] = ", ";
    47     StringBuilder result;
    48     // Compute the required capacity in advance to reduce allocations.
    49     result.reserveCapacity((sizeof(opening) - 1) + (5 * (sizeof(separator) - 1)) + 1 + x.length() + y.length() + width.length() + height.length() + radiusX.length() + radiusY.length() + (box.length() ? box.length() + 1 : 0));
    50     result.appendLiteral(opening);
    51     result.append(x);
    52     result.appendLiteral(separator);
    53     result.append(y);
    54     result.appendLiteral(separator);
    55     result.append(width);
    56     result.appendLiteral(separator);
    57     result.append(height);
    58     if (!radiusX.isNull()) {
    59         result.appendLiteral(separator);
    60         result.append(radiusX);
    61         if (!radiusY.isNull()) {
    62             result.appendLiteral(separator);
    63             result.append(radiusY);
    64         }
    65     }
    66     result.append(')');
    67     if (box.length()) {
    68         result.append(' ');
    69         result.append(box);
    70     }
    71     return result.toString();
    72 }
    73 
    74 String CSSBasicShapeRectangle::cssText() const
    75 {
    76     return buildRectangleString(m_x->cssText(),
    77         m_y->cssText(),
    78         m_width->cssText(),
    79         m_height->cssText(),
    80         m_radiusX.get() ? m_radiusX->cssText() : String(),
    81         m_radiusY.get() ? m_radiusY->cssText() : String(),
    82         m_layoutBox ? m_layoutBox->cssText() : String());
    83 }
    84 
    85 bool CSSBasicShapeRectangle::equals(const CSSBasicShape& shape) const
    86 {
    87     if (shape.type() != CSSBasicShapeRectangleType)
    88         return false;
    89 
    90     const CSSBasicShapeRectangle& other = static_cast<const CSSBasicShapeRectangle&>(shape);
    91     return compareCSSValuePtr(m_x, other.m_x)
    92         && compareCSSValuePtr(m_y, other.m_y)
    93         && compareCSSValuePtr(m_width, other.m_width)
    94         && compareCSSValuePtr(m_height, other.m_height)
    95         && compareCSSValuePtr(m_radiusX, other.m_radiusX)
    96         && compareCSSValuePtr(m_radiusY, other.m_radiusY)
    97         && compareCSSValuePtr(m_layoutBox, other.m_layoutBox);
    98 }
    99 
    10043static String serializePositionOffset(const Pair& offset, const Pair& other)
    10144{
     
    189132}
    190133
    191 static String buildDeprecatedCircleString(const String& x, const String& y, const String& radius, const String& box)
    192 {
    193     StringBuilder result;
    194     char opening[] = "circle(";
    195     char separator[] = ", ";
    196     result.appendLiteral(opening);
    197     result.append(x);
    198     result.appendLiteral(separator);
    199     result.append(y);
    200     result.appendLiteral(separator);
    201     result.append(radius);
    202     result.append(')');
    203     if (box.length()) {
    204         result.append(' ');
    205         result.append(box);
    206     }
    207     return result.toString();
    208 }
    209 
    210 String CSSDeprecatedBasicShapeCircle::cssText() const
    211 {
    212     return buildDeprecatedCircleString(m_centerX->cssText(), m_centerY->cssText(), m_radius->cssText(), m_layoutBox ? m_layoutBox->cssText() : String());
    213 }
    214 
    215 bool CSSDeprecatedBasicShapeCircle::equals(const CSSBasicShape& shape) const
    216 {
    217     if (shape.type() != CSSDeprecatedBasicShapeCircleType)
    218         return false;
    219 
    220     const CSSDeprecatedBasicShapeCircle& other = static_cast<const CSSDeprecatedBasicShapeCircle&>(shape);
    221     return compareCSSValuePtr(m_centerX, other.m_centerX)
    222         && compareCSSValuePtr(m_centerY, other.m_centerY)
    223         && compareCSSValuePtr(m_radius, other.m_radius)
    224         && compareCSSValuePtr(m_layoutBox, other.m_layoutBox);
    225 }
    226 
    227134static String buildEllipseString(const String& radiusX, const String& radiusY, const String& centerX, const String& centerY, const String& box)
    228135{
     
    279186
    280187    const CSSBasicShapeEllipse& other = static_cast<const CSSBasicShapeEllipse&>(shape);
    281     return compareCSSValuePtr(m_centerX, other.m_centerX)
    282         && compareCSSValuePtr(m_centerY, other.m_centerY)
    283         && compareCSSValuePtr(m_radiusX, other.m_radiusX)
    284         && compareCSSValuePtr(m_radiusY, other.m_radiusY)
    285         && compareCSSValuePtr(m_layoutBox, other.m_layoutBox);
    286 }
    287 
    288 static String buildDeprecatedEllipseString(const String& x, const String& y, const String& radiusX, const String& radiusY, const String& box)
    289 {
    290     StringBuilder result;
    291     char opening[] = "ellipse(";
    292     char separator[] = ", ";
    293     result.appendLiteral(opening);
    294     result.append(x);
    295     result.appendLiteral(separator);
    296     result.append(y);
    297     result.appendLiteral(separator);
    298     result.append(radiusX);
    299     result.appendLiteral(separator);
    300     result.append(radiusY);
    301     result.append(')');
    302     if (box.length()) {
    303         result.append(' ');
    304         result.append(box);
    305     }
    306     return result.toString();
    307 }
    308 
    309 String CSSDeprecatedBasicShapeEllipse::cssText() const
    310 {
    311     return buildDeprecatedEllipseString(m_centerX->cssText(), m_centerY->cssText(), m_radiusX->cssText(), m_radiusY->cssText(), m_layoutBox ? m_layoutBox->cssText() : String());
    312 }
    313 
    314 bool CSSDeprecatedBasicShapeEllipse::equals(const CSSBasicShape& shape) const
    315 {
    316     if (shape.type() != CSSDeprecatedBasicShapeEllipseType)
    317         return false;
    318 
    319     const CSSDeprecatedBasicShapeEllipse& other = static_cast<const CSSDeprecatedBasicShapeEllipse&>(shape);
    320188    return compareCSSValuePtr(m_centerX, other.m_centerX)
    321189        && compareCSSValuePtr(m_centerY, other.m_centerY)
     
    393261}
    394262
    395 static String buildInsetRectangleString(const String& top, const String& right, const String& bottom, const String& left, const String& radiusX, const String& radiusY, const String& box)
    396 {
    397     char opening[] = "inset-rectangle(";
    398     char separator[] = ", ";
    399     StringBuilder result;
    400     // Compute the required capacity in advance to reduce allocations.
    401     result.reserveCapacity((sizeof(opening) - 1) + (5 * (sizeof(separator) - 1)) + 1 + top.length() + right.length() + bottom.length() + left.length() + radiusX.length() + radiusY.length() + (box.length() ? box.length() + 1 : 0));
    402     result.appendLiteral(opening);
    403     result.append(top);
    404     result.appendLiteral(separator);
    405     result.append(right);
    406     result.appendLiteral(separator);
    407     result.append(bottom);
    408     result.appendLiteral(separator);
    409     result.append(left);
    410     if (!radiusX.isNull()) {
    411         result.appendLiteral(separator);
    412         result.append(radiusX);
    413         if (!radiusY.isNull()) {
    414             result.appendLiteral(separator);
    415             result.append(radiusY);
    416         }
    417     }
    418     result.append(')');
    419     if (box.length()) {
    420         result.append(' ');
    421         result.append(box);
    422     }
    423     return result.toString();
    424 }
    425 
    426 String CSSBasicShapeInsetRectangle::cssText() const
    427 {
    428     return buildInsetRectangleString(m_top->cssText(),
    429         m_right->cssText(),
    430         m_bottom->cssText(),
    431         m_left->cssText(),
    432         m_radiusX.get() ? m_radiusX->cssText() : String(),
    433         m_radiusY.get() ? m_radiusY->cssText() : String(),
    434         m_layoutBox ? m_layoutBox->cssText() : String());
    435 }
    436 
    437 bool CSSBasicShapeInsetRectangle::equals(const CSSBasicShape& shape) const
    438 {
    439     if (shape.type() != CSSBasicShapeInsetRectangleType)
    440         return false;
    441 
    442     const CSSBasicShapeInsetRectangle& other = static_cast<const CSSBasicShapeInsetRectangle&>(shape);
    443     return compareCSSValuePtr(m_top, other.m_top)
    444         && compareCSSValuePtr(m_right, other.m_right)
    445         && compareCSSValuePtr(m_bottom, other.m_bottom)
    446         && compareCSSValuePtr(m_left, other.m_left)
    447         && compareCSSValuePtr(m_radiusX, other.m_radiusX)
    448         && compareCSSValuePtr(m_radiusY, other.m_radiusY)
    449         && compareCSSValuePtr(m_layoutBox, other.m_layoutBox);
    450 }
    451 
    452263static String buildInsetString(const String& top, const String& right, const String& bottom, const String& left,
    453264    const String& topLeftRadiusWidth, const String& topLeftRadiusHeight,
Note: See TracChangeset for help on using the changeset viewer.