Changeset 165490 in webkit for trunk/Source/JavaScriptCore/heap/HandleSet.h

Timestamp:

Mar 12, 2014, 11:29:00 AM (11 years ago)

Author:

[email protected]

Message:

Remove HandleSet::m_nextToFinalize
​https://bugs.webkit.org/show_bug.cgi?id=130109

Reviewed by Mark Lam.

This is a remnant of when HandleSet contained things that needed to be finalized.

• heap/HandleSet.cpp:

(JSC::HandleSet::HandleSet):
(JSC::HandleSet::writeBarrier):

• heap/HandleSet.h:

(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):

File:

• trunk/Source/JavaScriptCore/heap/HandleSet.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/heap/HandleSet.h

@@ -101 +101 @@
     SentinelLinkedList<Node> m_immediateList;
     SinglyLinkedList<Node> m_freeList;
-    Node* m_nextToFinalize;
 };
 
@@ -126 +125 @@
 inline HandleSlot HandleSet::allocate()
 {
-    // Forbid assignment to handles during the finalization phase, since it would violate many GC invariants.
-    // File a bug with stack trace if you hit this.
-    RELEASE_ASSERT(!m_nextToFinalize);
-
     if (m_freeList.isEmpty())
         grow();
@@ -142 +137 @@
 {
     HandleSet::Node* node = toNode(handle);
-    if (node == m_nextToFinalize) {
-        ASSERT(m_nextToFinalize->next());
-        m_nextToFinalize = m_nextToFinalize->next();
-    }
-
     SentinelLinkedList<HandleSet::Node>::remove(node);
     m_freeList.push(node);