Changeset 16606 in webkit for trunk/JavaScriptCore/kjs/function.h

Timestamp:

Sep 27, 2006, 5:58:52 PM (19 years ago)

Author:

kmccullo

Message:

Reviewed by Adele.

Fixes a GC stack overflow crash.
The change is to move from a linked list implementation of Parameters to a Vector.
The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.

• kjs/function.cpp: (KJS::Parameter::Parameter): (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:

File:

• trunk/JavaScriptCore/kjs/function.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/function.h

@@ -27 +27 @@
 #include "internal.h"
 #include <wtf/OwnPtr.h>
+#include <wtf/Vector.h>
 
 namespace KJS {
@@ -93 +94 @@
     virtual void mark();
   protected:
-    OwnPtr<Parameter> param;
+    Vector<Parameter> params;
 
   private: