Changeset 167031 in webkit for trunk/Source/JavaScriptCore/interpreter/ProtoCallFrame.h

Timestamp:

Apr 9, 2014, 1:23:20 PM (11 years ago)

Author:

[email protected]

Message:

Ensure that LLINT accessing of the ProtoCallFrame is big endian friendly.
<​https://webkit.org/b/131449>

Reviewed by Mark Hahnenberg.

Change ProtoCallFrame::paddedArgCount to be of type uint32_t. The argCount
that it pads is of type int anyway. It doesn't need to be 64 bit. This
also makes it work with the LLINT which is loading it with a loadi
instruction.

We should add the PayLoadOffset to ProtoCallFrame::argCountAndCodeOriginValue
when loading the argCount.

• interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::setPaddedArgCount):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

File:

• trunk/Source/JavaScriptCore/interpreter/ProtoCallFrame.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/interpreter/ProtoCallFrame.h

@@ -37 +37 @@
     Register argCountAndCodeOriginValue;
     Register thisArg;
-    size_t paddedArgCount;
+    uint32_t paddedArgCount;
     JSValue *args;
 
@@ -54 +54 @@
     int argumentCount() const { return argumentCountIncludingThis() - 1; }
     void setArgumentCountIncludingThis(int count) { argCountAndCodeOriginValue.payload() = count; }
-    void setPaddedArgCount(size_t argCount) { paddedArgCount = argCount; }
+    void setPaddedArgCount(uint32_t argCount) { paddedArgCount = argCount; }
 
     void clearCurrentVPC() { argCountAndCodeOriginValue.tag() = 0; }