Changeset 167313 in webkit for trunk/Source/JavaScriptCore/parser/Lexer.cpp

Timestamp:

Apr 15, 2014, 10:46:42 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r167199 and r167251.
​https://bugs.webkit.org/show_bug.cgi?id=131678

Caused a DYEBench regression and does not seem to improve perf
on relevant websites (Requested by rniwa on #webkit).

Reverted changesets:

"Rewrite Function.bind as a builtin"
​https://bugs.webkit.org/show_bug.cgi?id=131083
​http://trac.webkit.org/changeset/167199

"Update test result"
​http://trac.webkit.org/changeset/167251

File:

• trunk/Source/JavaScriptCore/parser/Lexer.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -490 +490 @@
 
 template <typename T>
-Lexer<T>::Lexer(VM* vm, JSParserStrictness strictness, JSFunctionKind functionKind)
+Lexer<T>::Lexer(VM* vm, JSParserStrictness strictness)
     : m_isReparsing(false)
     , m_vm(vm)
     , m_parsingBuiltinFunction(strictness == JSParseBuiltin)
-    , m_functionKind(functionKind)
 {
 }
@@ -821 +820 @@
             else if (*ident == m_vm->propertyNames->undefinedKeyword)
                 tokenData->ident = &m_vm->propertyNames->undefinedPrivateName;
-            
             if (!ident)
                 return INVALID_PRIVATE_NAME_ERRORTOK;
-            
-            if (*ident == m_vm->propertyNames->IsConstructorPrivateName)
-                return m_functionKind == JSFunctionIsConstructorKind ? TRUETOKEN : FALSETOKEN;
-            
         }
         tokenData->ident = ident;
@@ -903 +897 @@
             else if (*ident == m_vm->propertyNames->undefinedKeyword)
                 tokenData->ident = &m_vm->propertyNames->undefinedPrivateName;
-            if (m_functionKind == JSFunctionIsConstructorKind) {
-                if (*ident == m_vm->propertyNames->IsConstructorPrivateName)
-                    return TRUETOKEN;
-                return FALSETOKEN;
-            }
             if (!ident)
                 return INVALID_PRIVATE_NAME_ERRORTOK;