Changeset 167313 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Apr 15, 2014, 10:46:42 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r167199 and r167251.
​https://bugs.webkit.org/show_bug.cgi?id=131678

Caused a DYEBench regression and does not seem to improve perf
on relevant websites (Requested by rniwa on #webkit).

Reverted changesets:

"Rewrite Function.bind as a builtin"
​https://bugs.webkit.org/show_bug.cgi?id=131083
​http://trac.webkit.org/changeset/167199

"Update test result"
​http://trac.webkit.org/changeset/167251

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -165 +165 @@
         virtual bool isBoolean() const { return false; }
         virtual bool isSpreadExpression() const { return false; }
-        virtual bool getBooleanConstant(bool&) const { return false; }
 
         virtual void emitBytecodeInConditionContext(BytecodeGenerator&, Label*, Label*, FallThroughMode);
@@ -215 +214 @@
 
     private:
-        
-        bool getBooleanConstant(bool& value) const override
-        {
-            value = false;
-            return true;
-        }
-        
         virtual bool isNull() const override { return true; }
         virtual JSValue jsValue(BytecodeGenerator&) const override { return jsNull(); }
@@ -230 +222 @@
         BooleanNode(const JSTokenLocation&, bool value);
         bool value() { return m_value; }
-        
-    private:
-        bool getBooleanConstant(bool& value) const override
-        {
-            value = m_value;
-            return true;
-        }
-
+
+    private:
         virtual bool isBoolean() const override { return true; }
         virtual JSValue jsValue(BytecodeGenerator&) const override { return jsBoolean(m_value); }
@@ -251 +237 @@
 
     private:
-        bool getBooleanConstant(bool& value) const override
-        {
-            value = (bool)m_value;
-            return true;
-        }
         virtual bool isNumber() const override { return true; }
         virtual JSValue jsValue(BytecodeGenerator&) const override { return jsNumber(m_value); }