Changeset 167313 in webkit for trunk/Source/JavaScriptCore/parser/Parser.h

Timestamp:

Apr 15, 2014, 10:46:42 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r167199 and r167251.
​https://bugs.webkit.org/show_bug.cgi?id=131678

Caused a DYEBench regression and does not seem to improve perf
on relevant websites (Requested by rniwa on #webkit).

Reverted changesets:

"Rewrite Function.bind as a builtin"
​https://bugs.webkit.org/show_bug.cgi?id=131083
​http://trac.webkit.org/changeset/167199

"Update test result"
​http://trac.webkit.org/changeset/167251

File:

• trunk/Source/JavaScriptCore/parser/Parser.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/parser/Parser.h

@@ -412 +412 @@
 
 public:
-    Parser(VM*, const SourceCode&, FunctionParameters*, const Identifier&, JSParserStrictness, JSParserMode, JSFunctionKind);
+    Parser(VM*, const SourceCode&, FunctionParameters*, const Identifier&, JSParserStrictness, JSParserMode);
     ~Parser();
 
@@ -955 +955 @@
 
 template <class ParsedNode>
-PassRefPtr<ParsedNode> parse(VM* vm, const SourceCode& source, FunctionParameters* parameters, const Identifier& name, JSParserStrictness strictness, JSParserMode parserMode, JSFunctionKind functionKind, ParserError& error, JSTextPosition* positionBeforeLastNewline = 0)
+PassRefPtr<ParsedNode> parse(VM* vm, const SourceCode& source, FunctionParameters* parameters, const Identifier& name, JSParserStrictness strictness, JSParserMode parserMode, ParserError& error, JSTextPosition* positionBeforeLastNewline = 0)
 {
     SamplingRegion samplingRegion("Parsing");
@@ -961 +961 @@
     ASSERT(!source.provider()->source().isNull());
     if (source.provider()->source().is8Bit()) {
-        Parser<Lexer<LChar>> parser(vm, source, parameters, name, strictness, parserMode, functionKind);
+        Parser<Lexer<LChar>> parser(vm, source, parameters, name, strictness, parserMode);
         RefPtr<ParsedNode> result = parser.parse<ParsedNode>(error);
         if (positionBeforeLastNewline)
@@ -973 +973 @@
         return result.release();
     }
-    Parser<Lexer<UChar>> parser(vm, source, parameters, name, strictness, parserMode, functionKind);
+    Parser<Lexer<UChar>> parser(vm, source, parameters, name, strictness, parserMode);
     RefPtr<ParsedNode> result = parser.parse<ParsedNode>(error);
     if (positionBeforeLastNewline)