Changeset 167326 in webkit for trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h

Timestamp:

Apr 15, 2014, 2:05:09 PM (11 years ago)

Author:

[email protected]

Message:

Objective-C API external object graphs don't handle generational collection properly
​https://bugs.webkit.org/show_bug.cgi?id=131634

Reviewed by Geoffrey Garen.

If the set of Objective-C objects transitively reachable through an object changes, we
need to update the set of opaque roots accordingly. If we don't, the next EdenCollection
won't rescan the external object graph, which would lead us to consider a newly allocated
JSManagedValue to be dead.

• API/JSBase.cpp:

(JSSynchronousEdenCollectForDebugging):

• API/JSVirtualMachine.mm:

(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(-[JSVirtualMachine isOldExternalObject:]):
(-[JSVirtualMachine addExternalRememberedObject:]):
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
(-[JSVirtualMachine externalRememberedSet]):
(scanExternalObjectGraph):
(scanExternalRememberedSet):

• API/JSVirtualMachineInternal.h:
• API/tests/testapi.mm:
• heap/Heap.cpp:

(JSC::Heap::markRoots):

• heap/Heap.h:

(JSC::Heap::slotVisitor):

• heap/SlotVisitor.h:
• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):

File:

• trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSVirtualMachineInternal.h

@@ -27 +27 @@
 #define JSVirtualMachineInternal_h
 
+#if JSC_OBJC_API_ENABLED
+
 #import <JavaScriptCore/JavaScriptCore.h>
-
-#if JSC_OBJC_API_ENABLED
 
 namespace JSC {
@@ -52 +52 @@
 
 void scanExternalObjectGraph(JSC::VM&, JSC::SlotVisitor&, void* root);
+void scanExternalRememberedSet(JSC::VM&, JSC::SlotVisitor&);
 
-#endif
+#endif // JSC_OBJC_API_ENABLED
 
 #endif // JSVirtualMachineInternal_h