Changeset 167612 in webkit for trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h

Timestamp:

Apr 21, 2014, 12:51:54 PM (11 years ago)

Author:

[email protected]

Message:

OSR exit should know about Int52 and Double constants
​https://bugs.webkit.org/show_bug.cgi?id=131945

Reviewed by Oliver Hunt.

The DFG OSR exit machinery's ignorance would lead to some constants becoming
jsUndefined() after OSR exit.

The FTL OSR exit machinery's ignorance just meant that we would sometimes use a
stackmap constant rather than baking the constant into the OSRExit data structure.
So, not a big deal, but worth fixing.

Also added some helpful hacks to jsc.cpp for testing such OSR exit pathologies.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

• dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasConstantNumber):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):

• jsc.cpp:

(GlobalObject::finishCreation):
(functionOtherFalse):
(functionUndefined):

• runtime/Intrinsic.h:
• tests/stress/fold-to-double-constant-then-exit.js: Added.

(foo):

• tests/stress/fold-to-int52-constant-then-exit.js: Added.

(foo):

File:

• trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGMinifiedNode.h

@@ -41 +41 @@
     switch (type) {
     case JSConstant:
+    case Int52Constant:
+    case DoubleConstant:
     case WeakJSConstant:
     case PhantomArguments:
@@ -85 +87 @@
     static bool hasConstantNumber(NodeType type)
     {
-        return type == JSConstant;
+        return type == JSConstant || type == Int52Constant || type == DoubleConstant;
     }
     static bool hasWeakConstant(NodeType type)