Changeset 167813 in webkit for trunk/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp

Timestamp:

Apr 25, 2014, 11:51:20 AM (11 years ago)

Author:

[email protected]

Message:

Remove unused parameter from codeblock linking function
​https://bugs.webkit.org/show_bug.cgi?id=132199

Reviewed by Anders Carlsson.

No change in behaviour. This is just a small change to make it
slightly easier to reason about what the offsets in UnlinkedFunctionExecutable
actually mean.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::link):

• bytecode/UnlinkedCodeBlock.h:
• runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

File:

• trunk/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp

@@ -125 +125 @@
 }
 
-FunctionExecutable* UnlinkedFunctionExecutable::link(VM& vm, const SourceCode& source, size_t lineOffset, size_t sourceOffset)
+FunctionExecutable* UnlinkedFunctionExecutable::link(VM& vm, const SourceCode& source, size_t lineOffset)
 {
     unsigned firstLine = lineOffset + m_firstLineOffset;
-    unsigned startOffset = sourceOffset + m_startOffset;
     bool startColumnIsOnFirstSourceLine = !m_firstLineOffset;
     unsigned startColumn = m_unlinkedBodyStartColumn + (startColumnIsOnFirstSourceLine ? source.startColumn() : 1);
     bool endColumnIsOnStartLine = !m_lineCount;
     unsigned endColumn = m_unlinkedBodyEndColumn + (endColumnIsOnStartLine ? startColumn : 1);
-    SourceCode code(source.provider(), startOffset, startOffset + m_sourceLength, firstLine, startColumn);
+    SourceCode code(source.provider(), m_startOffset, m_startOffset + m_sourceLength, firstLine, startColumn);
     return FunctionExecutable::create(vm, code, this, firstLine, firstLine + m_lineCount, startColumn, endColumn);
 }