Changeset 169823 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

Timestamp:

Jun 11, 2014, 1:16:42 PM (11 years ago)

Author:

[email protected]

Message:

Always inline JSValue::get() and Structure::get().
<​https://webkit.org/b/133755>

Reviewed by Ryosuke Niwa.

These functions get really hot, so ask the compiler to be more
aggressive about inlining them.

~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
through GetByVal.

• runtime/JSArrayIterator.cpp:
• runtime/JSCJSValue.cpp:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::get):

• runtime/JSPromiseDeferred.cpp:
• runtime/StructureInlines.h:

(JSC::Structure::get):

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

@@ -666 +666 @@
 }
 
-inline JSValue JSValue::get(ExecState* exec, PropertyName propertyName) const
+ALWAYS_INLINE JSValue JSValue::get(ExecState* exec, PropertyName propertyName) const
 {
     PropertySlot slot(asValue());
@@ -672 +672 @@
 }
 
-inline JSValue JSValue::get(ExecState* exec, PropertyName propertyName, PropertySlot& slot) const
+ALWAYS_INLINE JSValue JSValue::get(ExecState* exec, PropertyName propertyName, PropertySlot& slot) const
 {
     // If this is a primitive, we'll need to synthesize the prototype -