Changeset 170042 in webkit for trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

Timestamp:

Jun 16, 2014, 8:55:14 PM (11 years ago)

Author:

[email protected]

Message:

Move forward declaration of bindings static functions into their implementation files
​https://bugs.webkit.org/show_bug.cgi?id=133943

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h:

Add a few identifiers that are needed by the DOM.

Source/WebCore:

• Moves the forward declaration of static functions for generated files to the implementation.
• Adds a new extended attribute, ForwardDeclareInHeader, for functions that still need a forward declaration in the header.

• bindings/js/JSDOMBinding.h:

(WebCore::nonCachingStaticFunctionGetter):
Move this helper here from JSDOMWindowCustom.cpp.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers.

• bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.

• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::putDelegate):
Switch to comparing the property name directly rather than looking up in the static table and
comparing function pointers and start using the nonCachingStaticFunctionGetter<> helper.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
Move forward declaration creation to the implementation file where possible.

• bindings/scripts/IDLAttributes.txt:

Add ForwardDeclareInHeader.

• page/DOMWindow.idl:
• page/History.idl:
• page/Location.idl:

Add ForwardDeclareInHeader where necessary.

File:

• trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h (modified) (5 diffs)

trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -65 +65 @@
     macro(anonymous) \
     macro(arguments) \
+    macro(assign) \
+    macro(back) \
     macro(bind) \
+    macro(blur) \
     macro(buffer) \
     macro(byteLength) \
@@ -77 +80 @@
     macro(cast) \
     macro(clear) \
+    macro(close) \
+    macro(closed) \
     macro(compilationKind) \
     macro(compilations) \
@@ -95 +100 @@
     macro(executionCount) \
     macro(exitKind) \
+    macro(focus) \
     macro(forEach) \
+    macro(forward) \
     macro(fromCharCode) \
     macro(get) \
     macro(global) \
+    macro(go) \
     macro(has) \
     macro(hasOwnProperty) \
     macro(hash) \
     macro(header) \
+    macro(href) \
     macro(id) \
     macro(ignoreCase) \
@@ -132 +141 @@
     macro(osrExits) \
     macro(parse) \
+    macro(postMessage) \
     macro(profiledBytecodes) \
     macro(propertyIsEnumerable) \
     macro(prototype) \
+    macro(reload) \
+    macro(replace) \
     macro(set) \
+    macro(showModalDialog) \
     macro(size) \
     macro(slice) \
@@ -152 +165 @@
     macro(toString) \
     macro(value) \
+    macro(valueOf) \
     macro(values) \
-    macro(valueOf) \
     macro(window) \
     macro(writable)