Changeset 170769 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp

Timestamp:

Jul 3, 2014, 2:04:07 PM (11 years ago)

Author:

[email protected]

Message:

SSA DCE should process blocks in forward order
​https://bugs.webkit.org/show_bug.cgi?id=134611

Reviewed by Andreas Kling.

• dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

• tests/stress/dead-value-with-mov-hint-in-another-block.js: Added.

(foo):

File:

• trunk/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp

@@ -107 +107 @@
         
         if (m_graph.m_form == SSA) {
-            // Need to process the graph in reverse DFS order, so that we get to the uses
-            // of a node before we get to the node itself.
             Vector<BasicBlock*> depthFirst;
             m_graph.getBlocksInDepthFirstOrder(depthFirst);
-            for (unsigned i = depthFirst.size(); i--;)
+            for (unsigned i = 0; i < depthFirst.size(); ++i)
                 fixupBlock(depthFirst[i]);
         } else {