Changeset 171013 in webkit for trunk/Source/JavaScriptCore/DerivedSources.make

Timestamp:

Jul 11, 2014, 2:54:19 PM (11 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Debugger Pause button does not work
​https://bugs.webkit.org/show_bug.cgi?id=134785

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

• CMakeLists.txt:
• DerivedSources.make:

Minification strips the sourceURL command. Add it back with minification.

Source/WebCore:

• CMakeLists.txt:
• DerivedSources.make:
• inspector/CommandLineAPIModuleSource.js:

Minification strips the sourceURL command. Add it back with minification.

Source/WebInspectorUI:
Previously we were automatically resuming if we had no recognized
call frames in the call stack we get when paused. However, we
were accidentally skipping over anonymous scripts instead of
just Web Inspector originated call frames.

Now that we allow anonymous scripts we can step into anonymous
scripts (e.g. evals, new Function(...)) as expected.

Also, remove the condition of automatically resuming if the
call stack was empty. The UI handles this with "No Call Frames".

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.debuggerDidPause):

File:

• trunk/Source/JavaScriptCore/DerivedSources.make (modified) (1 diff)

trunk/Source/JavaScriptCore/DerivedSources.make

@@ -148 +148 @@
 
 InjectedScriptSource.h : inspector/InjectedScriptSource.js $(JavaScriptCore)/inspector/scripts/jsmin.py $(JavaScriptCore)/inspector/scripts/xxd.pl
-        $(PYTHON) $(JavaScriptCore)/inspector/scripts/jsmin.py < $(JavaScriptCore)/inspector/InjectedScriptSource.js > ./InjectedScriptSource.min.js
+        echo "//# sourceURL=__WebInspectorInjectedScript__" > ./InjectedScriptSource.min.js
+        $(PYTHON) $(JavaScriptCore)/inspector/scripts/jsmin.py < $(JavaScriptCore)/inspector/InjectedScriptSource.js >> ./InjectedScriptSource.min.js
         $(PERL) $(JavaScriptCore)/inspector/scripts/xxd.pl InjectedScriptSource_js ./InjectedScriptSource.min.js InjectedScriptSource.h
         rm -f ./InjectedScriptSource.min.js