Changeset 171108 in webkit for trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

Timestamp:

Jul 15, 2014, 12:11:57 PM (11 years ago)

Author:

[email protected]

Message:

ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
​https://bugs.webkit.org/show_bug.cgi?id=134928

Reviewed by Andreas Kling.

• bytecode/CodeBlock.h:

(JSC::ScriptExecutable::forEachCodeBlock): Check for null CodeBlocks before calling forEachRelatedCodeBlock.

File:

• trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (modified) (1 diff)

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

@@ -1283 +1283 @@
     switch (type()) {
     case ProgramExecutableType: {
-        jsCast<ProgramExecutable*>(this)->m_programCodeBlock->forEachRelatedCodeBlock(std::forward<Functor>(functor));
+        if (CodeBlock* codeBlock = jsCast<ProgramExecutable*>(this)->m_programCodeBlock.get())
+            codeBlock->forEachRelatedCodeBlock(std::forward<Functor>(functor));
         break;
     }
         
     case EvalExecutableType: {
-        jsCast<EvalExecutable*>(this)->m_evalCodeBlock->forEachRelatedCodeBlock(std::forward<Functor>(functor));
+        if (CodeBlock* codeBlock = jsCast<EvalExecutable*>(this)->m_evalCodeBlock.get())
+            codeBlock->forEachRelatedCodeBlock(std::forward<Functor>(functor));
         break;
     }