Changeset 171115 in webkit for trunk/Source/JavaScriptCore/runtime/StructureRareDataInlines.h

Timestamp:

Jul 15, 2014, 2:05:43 PM (11 years ago)

Author:

[email protected]

Message:

Stores to PropertyTable use the Structure as the owner
​https://bugs.webkit.org/show_bug.cgi?id=134595

Reviewed by Darin Adler.

Since PropertyTable is the object that does the marking of these references, it should be the owner.

Also removed some unused parameters to other methods that historically used the Structure as the owner.

• runtime/JSPropertyNameIterator.h:

(JSC::StructureRareData::setEnumerationCache):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::copy):

• runtime/PropertyTable.cpp:

(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):

• runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::putSpecificValue):

• runtime/Structure.h:

(JSC::Structure::setObjectToStringValue):
(JSC::Structure::setPreviousID):

• runtime/StructureInlines.h:

(JSC::Structure::setEnumerationCache):

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::setObjectToStringValue):

File:

• trunk/Source/JavaScriptCore/runtime/StructureRareDataInlines.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/StructureRareDataInlines.h

@@ -36 +36 @@
 }
 
-inline void StructureRareData::setPreviousID(VM& vm, Structure*, Structure* structure)
+inline void StructureRareData::setPreviousID(VM& vm, Structure* structure)
 {
     m_previous.set(vm, this, structure);
@@ -51 +51 @@
 }
 
-inline void StructureRareData::setObjectToStringValue(VM& vm, const JSCell*, JSString* value)
+inline void StructureRareData::setObjectToStringValue(VM& vm, JSString* value)
 {
     m_objectToStringValue.set(vm, this, value);