Changeset 172113 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp

Timestamp:

Aug 5, 2014, 6:02:50 PM (11 years ago)

Author:

[email protected]

Message:

Fix resource leak of unclosed file descriptor.
​https://bugs.webkit.org/show_bug.cgi?id=135417

Patch by Przemyslaw Kuczynski <​[email protected]> on 2014-08-05
Reviewed by Darin Adler.

When open returns zero, fd handle leaks. Checking (fd > 0) needs to be replaced
with (fd != -1).

• assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.cpp

@@ -51 +51 @@
 #if OS(LINUX)
     int fd = open("/proc/self/auxv", O_RDONLY);
-    if (fd > 0) {
+    if (fd != -1) {
         Elf32_auxv_t aux;
         while (read(fd, &aux, sizeof(Elf32_auxv_t))) {