Changeset 172380 in webkit for trunk/Source/JavaScriptCore/parser/Lexer.cpp

Timestamp:

Aug 10, 2014, 1:07:34 PM (11 years ago)

Author:

[email protected]

Message:

JSC Lexer is allowing octals 08 and 09 in strict mode functions
​https://bugs.webkit.org/show_bug.cgi?id=135704

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-10
Reviewed by Oliver Hunt.

Return syntax error ("Decimal integer literals with a leading zero are
forbidden in strict mode") if a number starts with 0 and is followed
by a digit.

• parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

File:

• trunk/Source/JavaScriptCore/parser/Lexer.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -1665 +1665 @@
 
         record8('0');
+        if (strictMode && isASCIIDigit(m_current)) {
+            m_lexErrorMessage = "Decimal integer literals with a leading zero are forbidden in strict mode";
+            token = INVALID_OCTAL_NUMBER_ERRORTOK;
+            goto returnError;
+        }
         if (isASCIIOctalDigit(m_current)) {
             if (parseOctal(tokenData->doubleValue)) {
-                if (strictMode) {
-                    m_lexErrorMessage = "Octal escapes are forbidden in strict mode";
-                    token = INVALID_OCTAL_NUMBER_ERRORTOK;
-                    goto returnError;
-                }
                 token = NUMBER;
             }