Ignore:
Timestamp:
Aug 24, 2014, 5:26:14 PM (11 years ago)
Author:
Brian Burg
Message:

Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=136025

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This workaround can be removed since it is no longer necessary.

  • inspector/scripts/codegen/models.py:

(TypeReference.init):
(Type.raw_name):
(TypeDeclaration.init):

  • inspector/scripts/tests/type-declaration-object-type.json: Remove related test input.
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result: Rebaseline.

Source/WebCore:

Rename DOM.RGBA to DOM.RGBAColor to avoid name clashes with headers on Windows CE.
This workaround used to be special-cased in the bindings generator.

Type names are not used in protocol messages, so this does not introduce legacy issues.

  • inspector/protocol/DOM.json:

Source/WebInspectorUI:

Also rename DOM.RGBA in legacy protocol specifications.

  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r172888 r172897  
     12014-08-24  Brian J. Burg  <[email protected]>
     2
     3        Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
     4        https://bugs.webkit.org/show_bug.cgi?id=136025
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        This workaround can be removed since it is no longer necessary.
     9
     10        * inspector/scripts/codegen/models.py:
     11        (TypeReference.__init__):
     12        (Type.raw_name):
     13        (TypeDeclaration.__init__):
     14        * inspector/scripts/tests/type-declaration-object-type.json: Remove related test input.
     15        * inspector/scripts/tests/expected/type-declaration-object-type.json-result: Rebaseline.
     16
    1172014-08-23  Joseph Pecoraro  <[email protected]>
    218
Note: See TracChangeset for help on using the changeset viewer.