Changeset 172961 in webkit for trunk/Source/JavaScriptCore/dfg/DFGLazyJSValue.h

Timestamp:

Aug 26, 2014, 9:46:10 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r172940.
​https://bugs.webkit.org/show_bug.cgi?id=136256

Caused assertions on fast/storage/serialized-script-
value.html, and possibly flakiness on more tests (Requested by
ap on #webkit).

Reverted changeset:

"FTL should be able to do polymorphic call inlining"
​https://bugs.webkit.org/show_bug.cgi?id=135145
​http://trac.webkit.org/changeset/172940

File:

• trunk/Source/JavaScriptCore/dfg/DFGLazyJSValue.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGLazyJSValue.h

@@ -29 +29 @@
 #if ENABLE(DFG_JIT)
 
-#include "DFGCommon.h"
 #include "DFGFrozenValue.h"
 #include <wtf/text/StringImpl.h>
@@ -97 +96 @@
     TriState strictEqual(const LazyJSValue& other) const;
     
-    uintptr_t switchLookupValue(SwitchKind) const;
+    unsigned switchLookupValue() const
+    {
+        // NB. Not every kind of JSValue will be able to give you a switch lookup
+        // value, and this method will assert, or do bad things, if you use it
+        // for a kind of value that can't.
+        switch (m_kind) {
+        case KnownValue:
+            return value()->value().asInt32();
+        case SingleCharacterString:
+            return character();
+        default:
+            RELEASE_ASSERT_NOT_REACHED();
+            return 0;
+        }
+    }
     
     void dump(PrintStream&) const;