Changeset 173244 in webkit for trunk/Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp

Timestamp:

Sep 3, 2014, 5:28:50 PM (11 years ago)

Author:

[email protected]

Message:

CallEdgeProfile::visitWeak() shouldn't attempt to despecify empty profiles
​https://bugs.webkit.org/show_bug.cgi?id=136511

Reviewed by Geoffrey Garen.

• bytecode/CallEdgeProfile.cpp:

(JSC::CallEdgeProfile::worthDespecifying):
(JSC::CallEdgeProfile::visitWeak):
(JSC::CallEdgeProfile::mergeBack):

File:

• trunk/Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp

@@ -96 +96 @@
         return false;
     
-    if (!!m_primaryCallee && !JSC::worthDespecifying(m_primaryCallee))
-        return false;
+    bool didSeeEntry = false;
+    
+    if (!!m_primaryCallee) {
+        didSeeEntry = true;
+        if (!JSC::worthDespecifying(m_primaryCallee))
+            return false;
+    }
     
     if (m_otherCallees) {
         for (unsigned i = m_otherCallees->m_processed.size(); i--;) {
+            didSeeEntry = true;
             if (!JSC::worthDespecifying(m_otherCallees->m_processed[i].callee()))
                 return false;
@@ -106 +112 @@
     }
     
-    return true;
+    return didSeeEntry;
 }
 
@@ -132 +138 @@
         
         Vector<CallSpectrum::KeyAndCount> list = newSpectrum.buildList();
-        ASSERT(list.size());
+        RELEASE_ASSERT(list.size());
         m_primaryCallee = list.last().key;
         m_numCallsToPrimary = list.last().count;
@@ -208 +214 @@
     ConcurrentJITLocker locker(m_lock);
     
-    ASSERT(m_otherCallees);
-    ASSERT(m_otherCallees->m_temporarySpectrum);
+    RELEASE_ASSERT(m_otherCallees);
+    RELEASE_ASSERT(m_otherCallees->m_temporarySpectrum);
     
     if (!!m_primaryCallee)