Changeset 173896 in webkit for trunk/Source/JavaScriptCore/debugger/DebuggerScope.cpp

Timestamp:

Sep 23, 2014, 3:29:35 PM (11 years ago)

Author:

[email protected]

Message:

DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains.
<​https://webkit.org/b/137045>

Reviewed by Geoffrey Garen.

DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames
in the debugger stack, but only invalidates the DebuggerScope chain of the
top most frame. We should also invalidate all the DebuggerScope chains of
the other frames in the debugger stack.

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::invalidate):

• debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::invalidateChain):

File:

• trunk/Source/JavaScriptCore/debugger/DebuggerScope.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/debugger/DebuggerScope.cpp

@@ -143 +143 @@
 void DebuggerScope::invalidateChain()
 {
+    if (!isValid())
+        return;
+
     DebuggerScope* scope = this;
     while (scope) {
-        ASSERT(scope->isValid());
         DebuggerScope* nextScope = scope->m_next.get();
         scope->m_next.clear();
-        scope->m_scope.clear();
+        scope->m_scope.clear(); // This also marks this scope as invalid.
         scope = nextScope;
     }