Changeset 174469 in webkit for trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp

Timestamp:

Oct 8, 2014, 12:24:43 PM (11 years ago)

Author:

[email protected]

Message:

Add deprecation warning for CSSKeyframesRule::appendRule
​https://bugs.webkit.org/show_bug.cgi?id=137532
<rdar://problem/18585745>

Reviewed by Brent Fulgham.

Source/WebCore:

In r173982 (webkit.org/b/57910) we added insertRule to match
the spec. We should print a warning to the JS console suggesting
users move to insertRule.

• css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::appendRule): Add a message to the system
console.

• css/WebKitCSSKeyframesRule.h:

LayoutTests:

Update test expectations to include console message.

• animations/change-keyframes-expected.txt:

File:

• trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp (modified) (2 diffs)

trunk/Source/WebCore/css/WebKitCSSKeyframesRule.cpp

@@ -30 +30 @@
 #include "CSSRuleList.h"
 #include "CSSStyleSheet.h"
+#include "Document.h"
 #include "StyleProperties.h"
 #include "StyleSheet.h"
@@ -111 +112 @@
 }
 
+void WebKitCSSKeyframesRule::appendRule(const String& ruleText)
+{
+    if (CSSStyleSheet* parent = parentStyleSheet()) {
+        if (Document* ownerDocument = parent->ownerDocument())
+            ownerDocument->addConsoleMessage(MessageSource::JS, MessageLevel::Warning, ASCIILiteral("CSSKeyframesRule 'appendRule' function is deprecated.  Use 'insertRule' instead."));
+    }
+    insertRule(ruleText);
+}
+
 void WebKitCSSKeyframesRule::insertRule(const String& ruleText)
 {