Changeset 174610 in webkit for trunk/Source/JavaScriptCore/parser/Parser.cpp

Timestamp:

Oct 10, 2014, 1:30:32 PM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r174606.
​https://bugs.webkit.org/show_bug.cgi?id=137621

broke a JSC test (Requested by estes on #webkit).

Reverted changeset:

"Various arguments optimisations in codegen fail to account
for arguments being in lexical record"
​https://bugs.webkit.org/show_bug.cgi?id=137617
​http://trac.webkit.org/changeset/174606

File:

• trunk/Source/JavaScriptCore/parser/Parser.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -272 +272 @@
     IdentifierSet capturedVariables;
     bool modifiedParameter = false;
-    bool modifiedArguments = false;
-    scope->getCapturedVariables(capturedVariables, modifiedParameter, modifiedArguments);
+    scope->getCapturedVariables(capturedVariables, modifiedParameter);
     
     CodeFeatures features = context.features();
@@ -282 +281 @@
     if (modifiedParameter)
         features |= ModifiedParameterFeature;
-    if (modifiedArguments)
-        features |= ModifiedArgumentsFeature;
+    
     Vector<RefPtr<StringImpl>> closedVariables;
     if (m_parsingBuiltin) {
@@ -295 +293 @@
             if (scope->hasDeclaredParameter(Identifier(m_vm, variable.get())))
                 continue;
-
-            if (variable == m_vm->propertyNames->arguments.impl())
-                continue;
-
             closedVariables.append(variable);
         }