Changeset 174610 in webkit for trunk/Source/JavaScriptCore/parser/Parser.h

Timestamp:

Oct 10, 2014, 1:30:32 PM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r174606.
​https://bugs.webkit.org/show_bug.cgi?id=137621

broke a JSC test (Requested by estes on #webkit).

Reverted changeset:

"Various arguments optimisations in codegen fail to account
for arguments being in lexical record"
​https://bugs.webkit.org/show_bug.cgi?id=137617
​http://trac.webkit.org/changeset/174606

File:

• trunk/Source/JavaScriptCore/parser/Parser.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Parser.h

@@ -280 +280 @@
     }
 
-    void getCapturedVariables(IdentifierSet& capturedVariables, bool& modifiedParameter, bool& modifiedArguments)
+    void getCapturedVariables(IdentifierSet& capturedVariables, bool& modifiedParameter)
     {
         if (m_needsFullActivation || m_usesEval) {
@@ -293 +293 @@
         }
         modifiedParameter = false;
-        if (shadowsArguments())
-            modifiedArguments = true;
         if (m_declaredParameters.size()) {
             IdentifierSet::iterator end = m_writtenVariables.end();
             for (IdentifierSet::iterator ptr = m_writtenVariables.begin(); ptr != end; ++ptr) {
-                if (*ptr == m_vm->propertyNames->arguments.impl())
-                    modifiedArguments = true;
                 if (!m_declaredParameters.contains(*ptr))
                     continue;