Changeset 176508 in webkit for trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp

Timestamp:

Nov 22, 2014, 8:37:15 PM (11 years ago)

Author:

[email protected]

Message:

Clean up OwnPtr and PassOwnPtr in some of JS classes
​https://bugs.webkit.org/show_bug.cgi?id=138724

Reviewed by Filip Pizlo.

As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.

• builtins/BuiltinExecutables.h:

(JSC::BuiltinExecutables::create): Deleted.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::createRareDataIfNecessary):

• bytecode/StructureStubInfo.h:
• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):

• runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

• runtime/CodeCache.h:

(JSC::CodeCache::create): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::clearRareData):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::createRareDataIfNeeded):

• runtime/RegExpConstructor.h:
• runtime/SmallStrings.cpp:

(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):

• runtime/SmallStrings.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/SmallStrings.cpp

@@ -114 +114 @@
 {
     if (!m_storage)
-        m_storage = adoptPtr(new SmallStringsStorage);
+        m_storage = std::make_unique<SmallStringsStorage>();
     ASSERT(!m_singleCharacterStrings[character]);
     m_singleCharacterStrings[character] = JSString::createHasOtherOwner(*vm, PassRefPtr<StringImpl>(m_storage->rep(character)));
@@ -122 +122 @@
 {
     if (!m_storage)
-        m_storage = adoptPtr(new SmallStringsStorage);
+        m_storage = std::make_unique<SmallStringsStorage>();
     return m_storage->rep(character);
 }