Changeset 177401 in webkit for trunk/Source/JavaScriptCore/jit/JITOperations.cpp

Timestamp:

Dec 16, 2014, 3:08:24 PM (11 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r177380.
​https://bugs.webkit.org/show_bug.cgi?id=139707

"Breaks js/regres/elidable-new-object-* tests" (Requested by
msaboff_ on #webkit).

Reverted changeset:

"Fixes operationPutByIdOptimizes such that they check that the
put didn't"
​https://bugs.webkit.org/show_bug.cgi?id=139500
​http://trac.webkit.org/changeset/177380

File:

• trunk/Source/JavaScriptCore/jit/JITOperations.cpp (modified) (8 diffs)

trunk/Source/JavaScriptCore/jit/JITOperations.cpp

@@ -274 +274 @@
     JSValue baseValue = JSValue::decode(encodedBase);
     PutPropertySlot slot(baseValue, true, exec->codeBlock()->putByIdContext());
-
-    Structure* structure = baseValue.isCell() ? baseValue.asCell()->structure(*vm) : nullptr;
+    
     baseValue.put(exec, ident, value, slot);
     
@@ -282 +281 @@
     
     if (stubInfo->seen)
-        repatchPutByID(exec, baseValue, structure, ident, slot, *stubInfo, NotDirect);
+        repatchPutByID(exec, baseValue, ident, slot, *stubInfo, NotDirect);
     else
         stubInfo->seen = true;
@@ -298 +297 @@
     JSValue baseValue = JSValue::decode(encodedBase);
     PutPropertySlot slot(baseValue, false, exec->codeBlock()->putByIdContext());
-
-    Structure* structure = baseValue.isCell() ? baseValue.asCell()->structure(*vm) : nullptr;    
+    
     baseValue.put(exec, ident, value, slot);
     
@@ -306 +304 @@
     
     if (stubInfo->seen)
-        repatchPutByID(exec, baseValue, structure, ident, slot, *stubInfo, NotDirect);
+        repatchPutByID(exec, baseValue, ident, slot, *stubInfo, NotDirect);
     else
         stubInfo->seen = true;
@@ -323 +321 @@
     PutPropertySlot slot(baseObject, true, exec->codeBlock()->putByIdContext());
     
-    Structure* structure = baseObject->structure(*vm);
     baseObject->putDirect(exec->vm(), ident, value, slot);
     
@@ -330 +327 @@
     
     if (stubInfo->seen)
-        repatchPutByID(exec, baseObject, structure, ident, slot, *stubInfo, Direct);
+        repatchPutByID(exec, baseObject, ident, slot, *stubInfo, Direct);
     else
         stubInfo->seen = true;
@@ -347 +344 @@
     PutPropertySlot slot(baseObject, false, exec->codeBlock()->putByIdContext());
     
-    Structure* structure = baseObject->structure(*vm);
     baseObject->putDirect(exec->vm(), ident, value, slot);
     
@@ -354 +350 @@
     
     if (stubInfo->seen)
-        repatchPutByID(exec, baseObject, structure, ident, slot, *stubInfo, Direct);
+        repatchPutByID(exec, baseObject, ident, slot, *stubInfo, Direct);
     else
         stubInfo->seen = true;