Changeset 177995 in webkit for trunk/Source/JavaScriptCore/interpreter/JSStack.cpp

Timestamp:

Jan 6, 2015, 2:24:15 PM (11 years ago)

Author:

[email protected]

Message:

ADDRESS_SANITIZER macro is overloaded
​https://bugs.webkit.org/show_bug.cgi?id=140130

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

• interpreter/JSStack.cpp: (JSC::JSStack::sanitizeStack): Use the new macro.

This code is nearly unused (only compiled in when JIT is disabled at build time),
however I've been told that it's best to keep it.

Source/WebCore:

• platform/RefCountedSupplement.h:
• platform/Supplementable.h:

Change the conditional to ENABLE(SECURITY_ASSERTIONS). These checks will be used
in debug builds, and also when one explicitly passes -DENABLE_SECURITY_ASSERTIONS.

Source/WTF:

• wtf/Compiler.h: Added an ASAN_ENABLED macro. The abbreviation should become well

known - we already use it in tools.

• wtf/Assertions.h:
• wtf/RefCounted.h:
• wtf/SizeLimits.cpp:

Change the conditional to ENABLE(SECURITY_ASSERTIONS). These checks will be used
in debug builds, and also when one explicitly passes -DENABLE_SECURITY_ASSERTIONS.

Tools:

• WebKitTestRunner/TestController.cpp: Use the new macro.

File:

• trunk/Source/JavaScriptCore/interpreter/JSStack.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/interpreter/JSStack.cpp

@@ -119 +119 @@
 void JSStack::sanitizeStack()
 {
-#if !defined(ADDRESS_SANITIZER)
+#if !ASAN_ENABLED
     ASSERT(topOfStack() <= baseOfStack());