Changeset 178756 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

Timestamp:

Jan 20, 2015, 2:43:06 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r178751.
​https://bugs.webkit.org/show_bug.cgi?id=140694

Caused 32-bit JSC test failures (Requested by JoePeck on
#webkit).

Reverted changeset:

"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
​https://bugs.webkit.org/show_bug.cgi?id=140426
​http://trac.webkit.org/changeset/178751

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

@@ -120 +120 @@
     VM& vm = exec->vm();
 
-    if (Optional<uint32_t> index = propertyName.asIndex()) {
-        putToPrimitiveByIndex(exec, index.value(), value, slot.isStrictMode());
+    unsigned index = propertyName.asIndex();
+    if (index != PropertyName::NotAnIndex) {
+        putToPrimitiveByIndex(exec, index, value, slot.isStrictMode());
         return;
     }