Changeset 178756 in webkit for trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp

Timestamp:

Jan 20, 2015, 2:43:06 PM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r178751.
​https://bugs.webkit.org/show_bug.cgi?id=140694

Caused 32-bit JSC test failures (Requested by JoePeck on
#webkit).

Reverted changeset:

"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
​https://bugs.webkit.org/show_bug.cgi?id=140426
​http://trac.webkit.org/changeset/178751

File:

• trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp

@@ -650 +650 @@
                 JSObject* object = asObject(objectStack.last());
                 PropertyName ident = identifierStack.last();
-                if (Optional<uint32_t> index = ident.asIndex())
-                    object->putDirectIndex(m_exec, index.value(), lastValue);
+                unsigned i = ident.asIndex();
+                if (i != PropertyName::NotAnIndex)
+                    object->putDirectIndex(m_exec, i, lastValue);
                 else
                     object->putDirect(m_exec->vm(), ident, lastValue);