Changeset 178928 in webkit for trunk/Source/JavaScriptCore/runtime/PropertyNameArray.cpp

Timestamp:

Jan 22, 2015, 11:34:34 AM (10 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r178894.
​https://bugs.webkit.org/show_bug.cgi?id=140775

Broke JSC and bindings tests (Requested by ap_ on #webkit).

Reverted changeset:

"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
​https://bugs.webkit.org/show_bug.cgi?id=140426
​http://trac.webkit.org/changeset/178894

File:

• trunk/Source/JavaScriptCore/runtime/PropertyNameArray.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/PropertyNameArray.cpp

@@ -34 +34 @@
     ASSERT(!identifier || identifier == StringImpl::empty() || identifier->isAtomic());
     if (!ASSERT_DISABLED) {
-        Optional<uint32_t> index = PropertyName(Identifier(m_vm, identifier)).asIndex();
-        ASSERT_UNUSED(index, !index || index.value() >= m_previouslyEnumeratedLength);
+        uint32_t index = PropertyName(Identifier(m_vm, identifier)).asIndex();
+        ASSERT_UNUSED(index, index == PropertyName::NotAnIndex || index >= m_previouslyEnumeratedLength);
     }