Changeset 179503 in webkit for trunk/Source/JavaScriptCore/dfg/DFGVariableEvent.cpp

Timestamp:

Feb 2, 2015, 3:32:00 PM (10 years ago)

Author:

[email protected]

Message:

VirtualRegister should really know how to dump itself
​https://bugs.webkit.org/show_bug.cgi?id=141171

Reviewed by Geoffrey Garen.

Gives VirtualRegister a dump() method that pretty-prints the virtual register. The rest of
the patch is all about using this new power.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::constantName):
(JSC::CodeBlock::registerName):

• bytecode/CodeBlock.h:

(JSC::missingThisObjectMarker): Deleted.

• bytecode/VirtualRegister.cpp: Added.

(JSC::VirtualRegister::dump):

• bytecode/VirtualRegister.h:

(WTF::printInternal): Deleted.

• dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::dump):

• dfg/DFGFlushedAt.cpp:

(JSC::DFG::FlushedAt::dump):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGPutLocalSinkingPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

• dfg/DFGValidate.cpp:

(JSC::DFG::Validate::reportValidationContext):

• dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

• dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpSpillInfo):

• ftl/FTLExitArgumentForOperand.cpp:

(JSC::FTL::ExitArgumentForOperand::dump):

• ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

• profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

File:

• trunk/Source/JavaScriptCore/dfg/DFGVariableEvent.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dfg/DFGVariableEvent.cpp

@@ -57 +57 @@
         break;
     case MovHintEvent:
-        out.print("MovHint(", id(), ", r", bytecodeRegister(), ")");
+        out.print("MovHint(", id(), ", ", bytecodeRegister(), ")");
         break;
     case SetLocalEvent:
         out.print(
-            "SetLocal(machine:r", machineRegister(), " -> bytecode:r", bytecodeRegister(),
+            "SetLocal(machine:", machineRegister(), " -> bytecode:", bytecodeRegister(),
             ", ", dataFormatToString(dataFormat()), ")");
         break;
@@ -86 +86 @@
 void VariableEvent::dumpSpillInfo(const char* name, PrintStream& out) const
 {
-    out.print(name, "(", id(), ", r", spillRegister(), ", ", dataFormatToString(dataFormat()), ")");
+    out.print(name, "(", id(), ", ", spillRegister(), ", ", dataFormatToString(dataFormat()), ")");
 }