Changeset 179504 in webkit for trunk/Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp

Timestamp:

Feb 2, 2015, 3:36:45 PM (10 years ago)

Author:

[email protected]

Message:

REGRESSION(r179477): arguments simplification no longer works
​https://bugs.webkit.org/show_bug.cgi?id=141169

Reviewed by Mark Lam.

The operations involved in callee/scope access don't exit and shouldn't get in the way
of strength-reducing a Flush to a PhantomLocal. Then the PhantomLocal shouldn't get in
the way of further such strength-reduction. We also need to canonicalize PhantomLocal
before running arguments simplification.

• dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

File:

• trunk/Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp

@@ -257 +257 @@
                     case Int52Constant:
                     case GetScope:
+                    case PhantomLocal:
+                    case GetCallee:
                         break;